Prompt for HTTPS/SSL connection types

yeoman / generator-polymer

Scaffold out a Polymer project

http://polymer-project.org

926 stars 149 forks source link

Prompt for HTTPS/SSL connection types #255

Closed jshcrowthe closed 8 years ago

jshcrowthe commented 8 years ago

This is a PR to address #248.

I have set the default connection type to be HTTPS but that can be changed if desired/needed.

samccone commented 8 years ago

LGTM :+1: thanks @jshcrowthe

jshcrowthe commented 8 years ago

I have updated the prompt (per @robdodson), would you like me to squash commits and re-push the branch?

samccone commented 8 years ago

+1 to a squash if you would not mind @jshcrowthe

robdodson commented 8 years ago

yup squash/rebase would be appreciated. thank you!

jshcrowthe commented 8 years ago

@robdodson, @samccone Squashed and Rebased! Interestingly enough Travis build failed for iojs. I reran the tests locally and was unable to reproduce the error:

Not sure what happened there.

robdodson commented 8 years ago

oh it's probably fine. let me rerun the tests.

robdodson commented 8 years ago

All good now. Thanks @jshcrowthe !

jshcrowthe commented 8 years ago

Awesome thanks so much @robdodson and @samccone. #248 can also be closed.

Also thanks for your patience on this, took far too long to do the 15 line PR.