search

yeoman / generator-webapp

A gulp.js generator for modern webapps
3.77k stars 708 forks source link

Do we want to include by default Google Analytics? #735

Closed UlisesGascon closed 5 years ago

UlisesGascon commented 6 years ago

Hi!

Right now we embed Google Analytics into de generated HTML...

Do we want to add this behaviour as an option? Also it can be interesting to populate the Number from the user's input (UA-XXXXX-X).

What do you think?

silvenon commented 6 years ago

If we make it configurable, then we need to make it optional, and I don't think it's that big of a deal to just delete it if you don't want it.

Did I understand you correctly? Or did you mean that we could include Google Analytics in a different way?

UlisesGascon commented 6 years ago

Yes... my idea was to add it as optional like Modernizer ;-)

silvenon commented 6 years ago

I don't have strong opinions either way. If you want to submit a PR to make it optional, just make sure that it's on by default. Concerning specifying ID, I'm not sure if at that point people generally know it in advance, in my mind they usually create one afterwards. While I like to give people as much power as possible, I also don't want the number of questions to be overwhelming.

UlisesGascon commented 6 years ago

Awesome, I will generate a PR after I finish with #700 ;-)