silvenon
commented
4 years ago Actually, in lintTest we would have to lose the dest part to prevent writing the file:
function lintTest() {
return lintBase('test/spec/**/*.js');
};Closed erniehs-zz closed 4 years ago
silvenon
commented
4 years ago Actually, in lintTest we would have to lose the dest part to prevent writing the file:
function lintTest() {
return lintBase('test/spec/**/*.js');
};
erniehs-zz
commented
4 years ago Perhaps write the lint dest to tmp?
Get Outlook for Androidhttps://aka.ms/ghei36
From: Matija Marohnić notifications@github.com Sent: Sunday, February 23, 2020 7:08:56 PM To: yeoman/generator-webapp generator-webapp@noreply.github.com Cc: Ernest Hope Stephenson ernie_hs@hotmail.com; Author author@noreply.github.com Subject: Re: [yeoman/generator-webapp] lint infinite loop (#770)
Actually, in lintTest we would have to lose the dest part to prevent writing the file:
function lintTest() { return lintBase('test/spec/*/.js'); };
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yeoman/generator-webapp/pull/770?email_source=notifications&email_token=ABHZYRWYXVJJVKZDVOCSU3DREK3TRA5CNFSM4KZQP2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWC7FI#issuecomment-590098325, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHZYRTLMH3NPSYNCFISUULREK3TRANCNFSM4KZQP2TQ.
silvenon
commented
4 years ago It would be misleading to write files that we won't use. Is there a reason why you want to write them somewhere?
erniehs-zz
commented
4 years ago Not really I was thinking that they rewrote the files in the editor at times (during infinite loop) however if loop is gone the fine 🙂
Get Outlook for Androidhttps://aka.ms/ghei36
From: Matija Marohnić notifications@github.com Sent: Sunday, February 23, 2020 7:34:21 PM To: yeoman/generator-webapp generator-webapp@noreply.github.com Cc: Ernest Hope Stephenson ernie_hs@hotmail.com; Author author@noreply.github.com Subject: Re: [yeoman/generator-webapp] lint infinite loop (#770)
It would be misleading to write files that we won't use. Is there a reason why you want to write them somewhere?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yeoman/generator-webapp/pull/770?email_source=notifications&email_token=ABHZYRX763PR3WESGFCYQLTREK6S3A5CNFSM4KZQP2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWDVAQ#issuecomment-590101122, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHZYRTWPD2YYBPG4ZBHGI3REK6S3ANCNFSM4KZQP2TQ.
silvenon
commented
4 years ago Great! Are you willing to add these changes to your PR? And leave the watch part.
erniehs-zz
commented
4 years ago Hola,
I will have a go implementing these changes
Cheers 🙂
Get Outlook for Androidhttps://aka.ms/ghei36
From: Matija Marohnić notifications@github.com Sent: Monday, February 24, 2020 8:27:26 AM To: yeoman/generator-webapp generator-webapp@noreply.github.com Cc: Ernest Hope Stephenson ernie_hs@hotmail.com; Author author@noreply.github.com Subject: Re: [yeoman/generator-webapp] lint infinite loop (#770)
Great, are you willing to add these changes to your PR?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yeoman/generator-webapp/pull/770?email_source=notifications&email_token=ABHZYRVF2E5EL6EFO4LUT33RENZF5A5CNFSM4KZQP2T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMW2V2Q#issuecomment-590195434, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHZYRWK5QYUPII3DS5DO5TRENZF5ANCNFSM4KZQP2TQ.
erniehs-zz
commented
4 years ago The browser refresh hppens twice as it occurs in lint base. The server reload part is not needed here it seems.
Ernie
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Matija Marohnićmailto:notifications@github.com Sent: 27 February 2020 14:50 To: yeoman/generator-webappmailto:generator-webapp@noreply.github.com Cc: Ernest Hope Stephensonmailto:ernie_hs@hotmail.com; Authormailto:author@noreply.github.com Subject: Re: [yeoman/generator-webapp] lint infinite loop (#770)
@silvenon requested changes on this pull request.
In app/templates/gulpfile.jshttps://github.com/yeoman/generator-webapp/pull/770#discussion_r385136871:
@@ -213,8 +212,7 @@ function startTestServer() {
});
watch('app/scripts/*/.js', scripts);
watch(['test/spec/*/.js', 'test/index.html']).on('change', server.reload);
watch('test/spec/*/.js', lintTest);
watch(['test/spec/*/.js', 'test/index.html'], lintTest);
Why is this part changed? I suggest returning it to the way it was: ⬇️ Suggested change
watch(['test/spec/*/.js', 'test/index.html'], lintTest);
watch(['test/spec/*/.js', 'test/index.html']).on('change', server.reload);
watch('test/spec/*/.js', lintTest);
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/yeoman/generator-webapp/pull/770?email_source=notifications&email_token=ABHZYRQ4WZ3TETYSPKUENGTRE7AL7A5CNFSM4KZQP2T2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCXGAZQA#pullrequestreview-365694144, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABHZYRV3MLVR3ZI3IURLJQTRE7AL7ANCNFSM4KZQP2TQ.
Fixes #769.