search

yeoman / grunt-bower-requirejs

[DEPRECATED] Grunt task - Automagically wire-up installed Bower components into your RequireJS config
198 stars 24 forks source link

Paths created with double quotes #37

Closed Robinfr closed 9 years ago

Robinfr commented 9 years ago

All the paths in the config are generated with double quotes, these should be single quotes.

arthurvr commented 9 years ago

All the paths in the config are generated with double quotes, these should be single quotes.

And why? Code style is just a personal opinion and doesn't matter as you're not going to edit that file.

Robinfr commented 9 years ago

Because it causes jslint/jshint to complain which will be used in most JS projects.

arthurvr commented 9 years ago

You should just let JSHint ignore that file, then. It's a file you don't write so it doesn't make sense to lint it.

Robinfr commented 9 years ago

That's not true as you might write shims. And more often than not you also start the application from that file.

Arthur Verschaeve notifications@github.comschreef:

You should just let JSHint ignore that file, then. It's a file you don't write so it doesn't make sense to lint it.

Reply to this email directly or view it on GitHub: https://github.com/yeoman/grunt-bower-requirejs/issues/37#issuecomment-110767434

arthurvr commented 9 years ago

Well, though I think following the users preferred code style will be a little unrealistic, this issue should be opened in the bower-requirejs issue tracker. This is just the grunt task.

I anyways think we shouldn't handle this, the user should just pipe it trough jscs --fix after we generated the file.