search

yeoman / update-notifier

Update notifications for your CLI app
BSD 2-Clause "Simplified" License
1.76k stars 132 forks source link

Should isGlobal work with npm link? #139

Open pofallon opened 6 years ago

pofallon commented 6 years ago

I'm currently developing a CLI that I've linked with npm link . in order to execute it as if it's globally installed (while I'm still working on it). However, executing it this way doesn't seem to trigger the "isGlobal" setting (I still have to explicitly set it to true to get "-g" to show up in the upgrade message). I suppose this won't matter once it's released to npm and people have actually installed it globally, but I was wondering if this is expected behavior. Should I expect isGlobal to default to true when I've simply npm link-ed it during development? Thanks!

sindresorhus commented 6 years ago

It will work fine when you publish, so I don't really see this as an issue worth caring about, but if anyone wants to do a PR to properly detect it, I'm fine with that.