Fix failing test - Githubissues

yeoman / update-notifier

Update notifications for your CLI app

BSD 2-Clause "Simplified" License

1.76k stars 132 forks source link

Fix failing test #153

Closed sindresorhus closed 5 years ago

sindresorhus commented 5 years ago

https://travis-ci.org/yeoman/update-notifier/jobs/512463652

litomore earned $30.00 by resolving this issue!

Checkout the Issuehunt explorer to discover more funded issues.

Need some help from other developers? Add your repositories on Issuehunt to raise funds.

LitoMore commented 5 years ago

I found the bug is here:

https://github.com/yeoman/update-notifier/blob/master/index.js#L120

The isNpm().isNpm returned a undefined.

~~Looks the ava is using the is-npm@1.0.0 for test.~~

LitoMore commented 5 years ago

~~We could mark as failing test temporary. Then wait for ava update the update-notifier to next version.~~

IssueHuntBot commented 5 years ago

@issuehunt has funded $30.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

IssueHuntBot commented 5 years ago

@sindresorhus has rewarded $21.00 to @litomore. See it on IssueHunt

:moneybag: Total deposit: $30.00
:tada: Repository reward(20%): $6.00
:wrench: Service fee(10%): $3.00