yeoman / update-notifier

Update notifications for your CLI app
BSD 2-Clause "Simplified" License
1.76k stars 132 forks source link

Added git-repo support for packages not on npm #190

Closed JoernBerkefeld closed 2 years ago

JoernBerkefeld commented 4 years ago

for issue #186 features

papb commented 4 years ago

Hello, what was the problem with is-installed-globally?

JoernBerkefeld commented 4 years ago

We tried it on 2 different Windows 10 machines and it didn't work. The docs for the underlying package are pointing to the npm command which returns the right global dir for my team's computers. However, internally that package was using environment variables instead that for whatever reason pointed elsewhere.

sindresorhus commented 2 years ago

I appreciate the pull request, but this is not something I want to maintain. I recommend publishing a fork with your changes instead.