yeoman / update-notifier

Update notifications for your CLI app
BSD 2-Clause "Simplified" License
1.76k stars 132 forks source link

switch to esmock, re #221 #225

Closed iambumblehead closed 2 years ago

iambumblehead commented 2 years ago

Fixes #221

I hope the changes here are OK and wanted to mention two things. One thing, some tests, expected to fail, were passing in my local environment. I found this this recent commit which indicated to me that the passing tests might be OK -- not sure. The tests in question are found in test/notifier.js.

The other thing is, esmock-imported modules are each using their own state, so tests could be updated in the future to run concurrently rather than sequentially (here).

sindresorhus commented 2 years ago

CI is failing

iambumblehead commented 2 years ago
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'clear-module' imported from /home/runner/work/update-notifier/update-notifier/test/fs-error.js

I'll resolve it in a moment

iambumblehead commented 2 years ago

its ready

sindresorhus commented 2 years ago

Thanks :)