search

yeoman / yeoman-app

A desktop app that scaffolds projects using Yeoman
988 stars 106 forks source link

Added skin-deep for better React tests #106

Closed ruyadorno closed 8 years ago

ruyadorno commented 8 years ago

It seems the small snippet from spec/helpers/createComponent.js evolved into a properly supported library with much more options that will be useful to allow me to test the prompts. This PR introduces this new lib: skin-deep

Also, updated dependencies to versions compatible with react@0.14.7

@stefanbuck for CR

stefanbuck commented 8 years ago

Nice find @ruyadorno. Overall looks good, just question. Why did you changed the patch version for some dependencies? Shouldn't this be handled by npm and the semver range pattern?

ruyadorno commented 8 years ago

for no reason whatsoever, I was just browsing the react-related dependencies and bumping up to latest versions but it happened that I also bumped the patch versions...

it's to avoid this kind of confusion that I tried to use x instead of patch versions in the past - anyways, do you want me to revert it? in this case we should rather standardize the use of 0 or x or * for the patch versions :blush:

stefanbuck commented 8 years ago

All good, thanks for clarification