search

yeoman / yeoman-app

A desktop app that scaffolds projects using Yeoman
988 stars 106 forks source link

2nd Style update #118

Closed NuroDev closed 3 years ago

NuroDev commented 8 years ago

Optional change I made that, in my opinion, makes the app look a lot smoother. Makes the header layered above the main generator content. As well as adding a box shadow to the header.

stefanbuck commented 8 years ago

I like the scrollable content but, I'm undecided about the shadow. Any thoughts on this @ruyadorno?

Before

before

After

after

stefanbuck commented 8 years ago

@Meadowcottage The header should disappear as soon as a generator is selected. This gives us more space on the next pages for the actual content.

ruyadorno commented 8 years ago

hi @Meadowcottage thanks for taking the time to propose this change but in the current format I don't think it's really a good idea to have a fixed header

one thing that could make the fixed position work is to resize the header to make it smaller as we scroll down, but then we would also need to resize the logo and maybe even change it to use the horizontal version: https://github.com/yeoman/media/blob/master/optimized/yeoman-2.svg

here's an example of how I see the sticky header working:

all that said, I don't think the current header image will support that, if we really want to work on an improvement I think it's worth updating it to use the svg assets from: https://github.com/yeoman/media and a solid/plain background

NuroDev commented 8 years ago

Was just an optional idea I had in mind. Wanted to get some feedback on whether you thought it would be a good feature to implement.

ruyadorno commented 8 years ago

@Meadowcottage 👍 sure thing, thank you very much, ideas are always welcomed!

let me know if you have the time to work on the provided feedback 😊

NuroDev commented 8 years ago

If I get some more free time in the near future I may start work on the feedback you've given. But for now I think I will put this style update on hold.