yeoman / yo

CLI tool for running Yeoman generators
http://yeoman.io
BSD 2-Clause "Simplified" License
3.8k stars 396 forks source link

Update `got` to v11 #794

Closed strmer15 closed 6 months ago

strmer15 commented 7 months ago

Purpose of this pull request?

What changes did you make?

I updated the got library to v11, which is the latest that can be used without switching to ESM-only. The only thing that it's currently being used for is to pull a blacklist from the web when installing a generator. The only change that was relevant was removing the {json: true} config in favor of the .json() function to return a Promise with a JSON body.

This package currently uses got v8, here are the releases between then and v11:

https://github.com/sindresorhus/got/releases/tag/v11.0.0 https://github.com/sindresorhus/got/releases/tag/v10.0.0 https://github.com/sindresorhus/got/releases/tag/v9.0.0

Is there anything you'd like reviewers to focus on?

The http://yeoman.io/blacklist.json website doesn't seem to exist - when I go to it in my browser I get a 404. Is this functionality even working currently, or should there be a different blacklist URL?

strmer15 commented 7 months ago

This should fix https://github.com/yeoman/yo/issues/780

strmer15 commented 6 months ago

@mshima Would you be able to review this?

mshima commented 6 months ago

@strmer15 please increase tests timeout for tests to pass.

strmer15 commented 6 months ago

@strmer15 please increase tests timeout for tests to pass.

Ok, will do - thanks!

strmer15 commented 6 months ago

@mshima Updated it just now and everything is passing :+1: