yeoman / yo

CLI tool for running Yeoman generators
http://yeoman.io
BSD 2-Clause "Simplified" License
3.82k stars 395 forks source link

Broken Outlook Extension (React JS) JavaScript Sample (Again) #813

Open RA-Davies opened 3 weeks ago

RA-Davies commented 3 weeks ago

Once again we appear to have a non-working (quite broken) yo generator for React JS Outlook add-in.

Previously, if you recall we had an invalid self-closed <Host xsi:type="MailHost"/> which - after quite some sleuthing I was able to resolve and build an add-in without issue. It looks like you've now solved, this but much worse things appear to happen using yo office when creating a React JS Outlook add-in (JavaScript) version... the package.json generated starts with:

0.2", "eslint-plugin-react": "^7.28.0", "file-loader": "^6.2.0", "find-process": "^1.4.4", "html-loader": "^5.0.0", "html-webpack-plugin": "^5.6.0",

... ..

Which of course is wrong and will lead to broken JSON that doesn't parse, leading to a project that won't build

Can I politely suggest you test these things before pushing them out?

In the meantime, does anyone have a valid (current) packages.json sample for this type of project (as I can see both this and the manifest.xml has changed a lot since I last used it)

RA-Davies commented 3 weeks ago

If it helps, the complete log after running yo office is:

I'm all done. Running npm install for you to install the required dependencies. If this fails, try running the command yourself.

npm WARN config cache-min This option has been deprecated in favor of --prefer-offline. npm ERR! code EJSONPARSE npm ERR! path C:...blahblah.../projectname/package.json npm ERR! JSON.parse Unexpected non-whitespace character after JSON at position 3 while parsing '0.2", npm ERR! JSON.parse "eslint-plugin-react": "^7.28.' npm ERR! JSON.parse Failed to parse JSON data. npm ERR! JSON.parse Note: package.json must be actual JSON, not just JavaScript.

npm ERR! A complete log of this run can be found in:.... .debug.log

No change to package.json was detected. No package manager install will be executed.