yeoman / yosay

Tell Yeoman what to say
BSD 2-Clause "Simplified" License
205 stars 43 forks source link

Add speech bubble tip #23

Closed mischah closed 8 years ago

mischah commented 8 years ago

Allo @yeoman,

I finally found the time to finalize this PR which will close #11. It’s ready for review :octocat:

Let me know what you think. Could the code be written more beautiful? Because it introduces mad conditions and weird numbers :grin:

sindresorhus commented 8 years ago

Found an issue:

❯ echo '1\n2\n2\n3\n4\n5\n6\n7\n8' | yosay

    ╭──────────────────────────╮
     _-----_     │             1            │
    |       |    │             2            │
    |--(o)--|    │             2            │
   `---------´   │             3            │
    ( _´U`_ )    │             4            │
    /___A___\   /│             5            │
     |  ~  |     │             6            │
   __'.___.'__   │             7            │
 ´   `  |° ´ Y ` │             8            │
                 ╰──────────────────────────╯
sindresorhus commented 8 years ago

// @SBoudrias @stephenplusplus

mischah commented 8 years ago

Found an issue:

Oops. Just fixed that 😊

mischah commented 8 years ago

Opps. Travis failed because of a linting error. Just fixed that and force pushed 1nce again.

mischah commented 8 years ago

@sindresorhus I’m done for now :octocat: Need some Feedback on some outdated diff comments.

sindresorhus commented 8 years ago

Answered

mischah commented 8 years ago

Thanks. I’m done for now. Did the constants thingie.

mischah commented 8 years ago

I like your new profile pic by the way 😻

</offtopic>

mischah commented 8 years ago

🔔 @SBoudrias @stephenplusplus @sindresorhus

😘

sindresorhus commented 8 years ago

Looks great! 🎉

Thanks for this awesome addition @mischah :)

mischah commented 8 years ago

My pleasure 😊