autoinstaller failing on win32 .zip file

elliot-eichen commented 4 years ago

I believe the geckodriver auto installer is looking for a win32 ,tar,gz file to unpack and install, but the latest package is a .zip file. I get a "Failed to download geckodriver archive: https://github.com/mozilla/geckodriver/releases/download/v0.27.0/geckodriver-v0.27.0-win32.tar.gz" when executing geckodriver_autoinstaller.install().

I tried downloading the .zip file, unzipping and then tar -cvz to a tar.gz, and replacing the download from github with a download from a local file, but then I get a "tarfile.ReadError: not a gzip file" error.

thanks!

Galsor commented 4 years ago

I had the same issue and got to the same conclusions. utils.get_geckodriver_url() is hard coded for tar.gz extension. After changing the extension, tarfile.open() was failing to open the zip file. in utils.download_geckodriver().

BalajiBaskarr commented 3 years ago

I too had the same issue , with the couple of changes in the utils code . It has resolved for the windows download .

Issue to fix :

Change if it is windows platform , we should be looking for the zip instead of .tar.gz

bblanchon commented 2 years ago

This sounds like an easy fix.

@yeongbin-jo, are you still maintaining this project? If so, you must fix this bug because it makes your package unusable for most users.

yeongbin-jo / python-geckodriver-autoinstaller

autoinstaller failing on win32 .zip file #7