search

yeonjuan / html-eslint

ESLint plugin for linting HTML
https://html-eslint.org
MIT License
161 stars 28 forks source link

refactor: refactor rules #156

Closed yeonjuan closed 1 year ago

yeonjuan commented 1 year ago
codecov[bot] commented 1 year ago

Codecov Report

Merging #156 (5d136d2) into main (671664a) will decrease coverage by 0.60%. The diff coverage is 94.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== - Coverage 98.68% 98.08% -0.60% ========================================== Files 43 43 Lines 915 942 +27 Branches 227 244 +17 ========================================== + Hits 903 924 +21 - Misses 12 18 +6 ``` | [Flag](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan) | Coverage Δ | | |---|---|---| | [unittest](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan) | `98.08% <94.73%> (-0.60%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan) | Coverage Δ | | |---|---|---| | [...ackages/eslint-plugin/lib/rules/element-newline.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvZWxlbWVudC1uZXdsaW5lLmpz) | `98.00% <100.00%> (-2.00%)` | :arrow_down: | | [...es/eslint-plugin/lib/rules/id-naming-convention.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvaWQtbmFtaW5nLWNvbnZlbnRpb24uanM=) | `89.47% <100.00%> (-4.98%)` | :arrow_down: | | [packages/eslint-plugin/lib/rules/indent.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvaW5kZW50Lmpz) | `100.00% <100.00%> (ø)` | | | [...kages/eslint-plugin/lib/rules/no-abstract-roles.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tYWJzdHJhY3Qtcm9sZXMuanM=) | `100.00% <100.00%> (ø)` | | | [...ages/eslint-plugin/lib/rules/no-accesskey-attrs.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tYWNjZXNza2V5LWF0dHJzLmpz) | `100.00% <100.00%> (ø)` | | | [...ges/eslint-plugin/lib/rules/no-aria-hidden-body.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tYXJpYS1oaWRkZW4tYm9keS5qcw==) | `100.00% <100.00%> (ø)` | | | [...ages/eslint-plugin/lib/rules/no-duplicate-attrs.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tZHVwbGljYXRlLWF0dHJzLmpz) | `100.00% <ø> (ø)` | | | [...ackages/eslint-plugin/lib/rules/no-duplicate-id.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tZHVwbGljYXRlLWlkLmpz) | `100.00% <100.00%> (ø)` | | | [.../eslint-plugin/lib/rules/no-extra-spacing-attrs.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8tZXh0cmEtc3BhY2luZy1hdHRycy5qcw==) | `98.63% <100.00%> (ø)` | | | [...ckages/eslint-plugin/lib/rules/no-inline-styles.js](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan#diff-cGFja2FnZXMvZXNsaW50LXBsdWdpbi9saWIvcnVsZXMvbm8taW5saW5lLXN0eWxlcy5qcw==) | `100.00% <100.00%> (ø)` | | | ... and [26 more](https://app.codecov.io/gh/yeonjuan/html-eslint/pull/156?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=YeonJuan) | |