yeonjuan / html-eslint

ESLint plugin for linting HTML
https://html-eslint.org
MIT License
161 stars 28 forks source link

Add support for regexp flags in id-naming-convention rule #180

Closed jdussouillez closed 8 months ago

jdussouillez commented 8 months ago

It would be nice to support regexp flags in the id-naming-convention rule.

This is not a priority feature but a nice to have.

I think there are different implementations possible :

I opened https://github.com/yeonjuan/html-eslint/pull/181 with the first solution. Feel free to modify/reject it.


BTW, it would be nice to have a very short "how to contribute" block in the readme, especially with the NPM scripts (Something like "before submitting PRs, run npm run format && npm run build && npm run lint && npm run test").

yeonjuan commented 8 months ago

@jdussouillez Thanks for the suggestion, Agree!

BTW, it would be nice to have a very short "how to contribute" block in the readme, especially with the NPM scripts (Something like "before submitting PRs, run npm run format && npm run build && npm run lint && npm run test").

Nice! I made a new issue for it. (https://github.com/yeonjuan/html-eslint/issues/182)

yeonjuan commented 8 months ago

Hi @jdussouillez Just a heads up. I'm planning to release a merged version this weekend.

jdussouillez commented 8 months ago

Hi, OK thanks!