yeonjuan / html-eslint

ESLint plugin for linting HTML
https://html-eslint.org
MIT License
161 stars 28 forks source link

ESLint v9 support #200

Open l3ender opened 3 months ago

l3ender commented 3 months ago

Hello, are there plans to update the plugin to support ESLint v9? Thanks!

https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

yeonjuan commented 3 months ago

Hi , @l3ender Let me investigate what we need to do to update to v9 👍 Thanks

yeonjuan commented 3 months ago

Hi @l3ender It looks like a breaking change affecting our plugin is planned for v10.0.0. So it should work fine in v9, let us know if you have any issues. Of course, we need to replace the depreacted methods for v10 support.

https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/#context-methods-becoming-properties

We are deprecating the methods in favor of the properties (added in v8.40.0). These methods will be removed in v10.0.0 (not v9.0.0) as they are not blocking language plugins work. Here’s an example that ensures the correct value is used:

tlabeeuw commented 3 months ago

Looks like the type in: packages/eslint-plugin/lib/index.js#L5-7 is referencing a deprecated type see types/eslint/index.d.ts#L1280-L1281.