search

yeonjuan / html-eslint

ESLint plugin for linting HTML
https://html-eslint.org
MIT License
158 stars 28 forks source link

Rename no-extra-spacing-attrs #204

Open RobertAKARobin opened 3 months ago

RobertAKARobin commented 3 months ago

202 adds functionality that prevents extra spacing inside tags even when there are no attributes, so the -attrs in no-extra-spacing-attrs isn't quite correct.

Maybe deprecate no-extra-spacing-attrs and add a new rule called no-extra-spacing-tags, or something?

(Not sure if @yeonjuan would prefer to deprecate the current rule and add a new one, or just rename the current rule)

See https://github.com/yeonjuan/html-eslint/pull/202#issuecomment-2260703134

yeonjuan commented 2 months ago

@RobertAKARobin Thank you for opening an issue!

Maybe deprecate no-extra-spacing-attrs and add a new rule called no-extra-spacing-tags, or something?

I think it would be better to deprecate it and add a new rule. 👍

RobertAKARobin commented 2 months ago

@yeonjuan Any particular way you want to deprecate the old rule? We could just replace all instances of "no-extra-spacing-attrs" with "no-extra-spacing-tags", but that could break things for users.

Ideally there would be a message that pops up when someone uses no-extra-spacing-attrs, e.g. "This rule has been deprecated. Please use no-extra-spacing-tags instead." Does ESLint offer something out-of-the-box for that?