search

yeoshuheng / pe

0 stars 0 forks source link

Possible duplicate entry. #7

Open yeoshuheng opened 2 months ago

yeoshuheng commented 2 months ago

Screenshot 2024-04-19 at 4.39.28 PM.png

Screenshot 2024-04-19 at 4.39.36 PM.png

It seems possible to add both users with the same name and phone number to fitbook. This is due to case insensitivity, it may be crucial to ensure the checks for names are done case insensitive.

In the context of fitbook, since it is extremely unlikely for someone to have both the same name and phone number. This may cause problems downstream in the use case of fitbook, especially when we work with the /find command to search for a name and a phone and subsequently use /fitadd, the next time I were to look up my client's exercise schedule, I would have 2 different schedules, and I might be confused which one is the most updated schedule.

soc-se-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate persons with case insensitive name can be added, unlike what is stated in the UG

image.png Based on UG, it is mentioned that name is case insensitive, so I would expect adding John and john to be considered duplicates and throw an error. However, I was able to add both John and john as seen below:

image.png Steps:

  1. add n/John p/98765432 e/john@gmail.com a/Clementi Ave 2 nt/BFF t/friend
  2. add n/john p/98765432 e/john@gmail.com a/Clementi Ave 2 nt/BFF t/friend

[original: nus-cs2103-AY2324S2/pe-interim#4341] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that we could have checked for case insensitivity more carefully. Thanks for pointing that out.

Thus, we accept this bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]