yeozhishen / pe

0 stars 0 forks source link

Empty activation bars with no object on page 15 of DG #15

Open yeozhishen opened 5 months ago

yeozhishen commented 5 months ago

image.png

The :Balance objects makes function calls like addition and subtraction to a non existing object, this does not conform to uml specification

soc-pe-bot commented 5 months ago

Team's Response

Attached is the complete sequence diagram:

image.png

Evidently, the empty rectangles are in-line with the :Money object and represent instances of it. We do not appreciate the bug tester selectively screenshotting our Developer Guide and misrepresenting this issue as the inclusion of a non-existing object, rather than a typo where the dotted line failed to encompass these objects.

As it is clear which object these "non existing object" are referencing if reading the entire diagram, the bug should be categorised under a severity of Very Low.

image.png

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: While these empty rectangles are in line with the :Money object, the uml diagram is still incorrect. Evidently, the :Money object is clearly initialized below the activation bars highlighted in the issue. This indicates that there is no object that these activation bars belong to, as the :Money object does not exist at the time when the activation bars are invoked. This hinders readability as the reader does not know which object the activation bars belong to, hence not being able to form a clear picture about the workings of the application properly.

If the developers wanted to indicate the use of static methods from the class being invoked, there instead should be a function call to another <<class>> Money object instead. As such, this is not merely a cosmetic issue, but rather a severity.medium issue with the UML diagram that will affect understanding of how the application works at the sequence diagram level.