search

yeozongyao / pe

0 stars 0 forks source link

Lack of encapsulation #18

Open yeozongyao opened 2 months ago

yeozongyao commented 2 months ago

image.png

With most of the variables being public, there is a lack of encapsulation in this design. Not sure if this is a mistake of diagram creation. Hence assigning this a severity of very low first.

nus-se-script commented 2 months ago

Team's Response

The access modifiers in the code are indeed what they were in the diagram, hence it is not a diagram issue.

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]