yeozongyao / pe

0 stars 0 forks source link

Cannot add names with special characters #2

Open yeozongyao opened 2 months ago

yeozongyao commented 2 months ago

image.png When trying to add student with a hypen in the name, which is very common across the world, I am faced with an error that a special character has been found.

This will cause the occasional hindrance to users, especially given these tuition centers manage a long list of students and it is highly likely that there will be students with a hyphen in them and if they were unable to input their full name, there may be issues in identifying them down the road. Hence, I am giving this a Medium severity.

nus-se-bot commented 2 months ago

Team's Response

Since the usability of the program is not greatly affected, and this hyphen is an easy fix, we are downgrading the severity. Moreover, the identification of a student is usually done by the other characters of their name, and not the hyphen; having a differing character will not affect identification that much.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

name input does not allow hyphen

image.png

names that have hyphens are not allowed to be added, even though these are not unrealistic names.

image.png

UG did mention this in FAQ, but there is no workaround implemented for students with these names, even though their preface mentioned this:

image.png

so technically every students' needs are not being addressed here?


[original: nus-cs2113-AY2324S2/pe-interim#91] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Since the usability of the program is not greatly affected, and this hyphen is an easy fix, we are downgrading the severity. Moreover, the identification of a student is usually done by the other characters of their name, and not the hyphen; having a differing character will not affect identification that much.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** While I agree that this may constitute NotInScope, I disagree that this is of severity very low. ![image.png](https://raw.githubusercontent.com/yeozongyao/pe/main/files/f110e9b1-fca9-4c31-8f55-359208c5ccde.png) The very low severity applies for bugs that are cosmetic and does not affect usage. Given that this bug comes under the validation of input, it is definitely not a cosmetic issue and should minimally fall under severity low. Hence, I propose a low severity for this bug.