yeozongyao / pe

0 stars 0 forks source link

Able to add a non-gender under gender #5

Open yeozongyao opened 2 months ago

yeozongyao commented 2 months ago

image.png

As seen above, I was able to add a gender called "mal" under adam. As much as we advocate for gender stereotyping in today's world, the gender has to at least make sense. Hence, a nonsensical gender like "mal' ought to have been identified and flagged out to the user, especially if the user manages a lot of students and is unable to capture such details.

Given that this feature does not severely affect the function of the programme, I shall be assigning this functionality bug a severity of low.

nus-se-script commented 2 months ago

Team's Response

Gender, which in the 21st century, is non-binary. Hence, as a tuition centre operating the neo-metropolitan society such as Singapore, we should be welcoming of people from identity types. As we do not have a sort by gender or even list by gender command in the program, the gender metric is purely meant for logging personal details purposes, and will only be displayed in the View or Edit commands.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to enter number as a gender

image.png

I am able to enter a number as a gender, this should not be allowed right, as genders are words?


[original: nus-cs2113-AY2324S2/pe-interim#1835] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We do not wish to comment on what can someone's gender be/not be.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I disagree that this bug should be invalidated. I would also like to change this bug to be a feature flaw, as I feel the issue lies in how this feature was designed and implemented by the team. While gender stereotyping is becoming a non-trend in today's world, if the gender input is allowed to take in any random value, then the field is not useful since the user will be able to input any random value as they wish. Some input validation is required for the entry to be a useful input. One example of doing so, would be like most programmes in the real world where they have input validation such as "male", "female" and "others". Hence, I believe that this is a valid bug
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I disagree that the severity should be very low for this bug. Given that this is a legitimate issue, this does not constitute a cosmetic flaw since the feature is inadequately developed, and the bug is not due to visual inadequacies. ![image.png](https://raw.githubusercontent.com/yeozongyao/pe/main/files/84da1a5c-8477-4cff-a627-6bd10be9fbaf.png) Hence, I believe this should be a feature bug of low severity.