yeozongyao / pe

0 stars 0 forks source link

Edits phone number even is invalid number is inputted #8

Open yeozongyao opened 5 months ago

yeozongyao commented 5 months ago

image.png

Editted a phone number to 00000099999999. It is an invalid phone number in this programme's context as stated, however, it may be a valid phone number in other countries with different coutry codes. Given that the student may be from other countries using other phone numbers, this invalid phone number should be flagged out to the user just in case they are saving an invalid phone number.

This is a serious issue that may cause clients to be uncontactable. Hence, i am assigning this a severity of medium.

nus-se-bot commented 5 months ago

Team's Response

It has been stated in our user guide that only a certain type of phone number can be input into the program. This specific case can also be seen as an extreme user behaviour as no country code starts with 0.

image.png

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree that this bug is NotInScope.

image.png

From a quick google search, it can be seen that there are many countries that have phone numbers that begin with a 09 or 08.

This is not an issue where users are not able to enter an invalid phone number, for examples numbers that start with 6.

This is an issue of users inputting a phone number that is valid in other countries but invalid in your programme's context, yet the programme still accepts these numbers WITHOUT rejecting these numbers as the programme would for phone numbers that begin with 6.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is not an issue where users are not able to enter an invalid phone number, for examples numbers that start with 6. This is an issue of users inputting a phone number that is valid in other countries but invalid in your programme's context, yet the programme still accepts these numbers WITHOUT rejecting these numbers as the programme would for phone numbers that begin with 6. And the acceptance of these numbers is dangerous, considering how important the phone numbers are for this programme: - used for distinguishing between repeated names - used for calling students Entering a wrong phone number and having the phone number accepted invalidates the entry altogether, since this programme is meant for managing the student population of a tuition center and not having the correct phone number means most importantly of all, the tuition center is not able to contact the student at all. This in fact is a very possible scenario given the student can very possibly come from another country and still uses their hometown phone number, or simply just entered the wrong number. Hence, this is definitely not a cosmetic issue and definitely not of severity very low.