search

yepher / CoreDataUtility

An OSX application that simplifies development and debugging of CoreData enabled applications.
519 stars 49 forks source link

Filter data: wrong index is passed to [MFLCoreDataIntrospection entityDescription:index] #6

Closed delebedev closed 11 years ago

delebedev commented 11 years ago
  1. Select the very first entity
  2. dataSource returns selected index = 1 and passes it to [self.objModel entities][1]

Expected Result: The index passed to [MFLCoreDataIntrospection entityDescription:index] should be 0 in this case.

yepher commented 11 years ago

I believe I fixed that in this commit but I will double check:

Commit: cad77bac263dba960f0a076098aa9fe1d18ba97d [cad77ba] Parents: d211c6a50f Author: Chris Wilson chris@mfluent.com Date: March 8, 2013 3:16:39 PM CST Labels: HEAD origin/master origin/develop origin/HEAD master develop

Fixes an exception when right clicking on "ENTITY' in the entity table.

delebedev commented 11 years ago

I believe it's not enough: check my pull request: https://github.com/yepher/CoreDataUtility/pull/7

delebedev commented 11 years ago

Btw, a noob question: I see my merge commits in the pull request, is that ok?

yepher commented 11 years ago

@garnett with regards to your "....merge commits in the pull request...". If I understand your question properly. You should "rebase" when you pull the changes. This will make the graph look better.