search

yeppog / pe

0 stars 0 forks source link

SHN date does not warn user about leap year dates. #6

Open yeppog opened 3 years ago

yeppog commented 3 years ago

image.png

Error message not specific as this is not due to a format issue but an invalid date of 2022-02-29 not existing (leap year issue). This could be a potential problem.

soc-pe-bot commented 3 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear Error Message for Invalid Arguments for find

image.png

Issue: When an invalid date is entered, all that was given is the error message above. Rather than mentioning it is an invalid date. (As it follows the format given)

[original: nus-cs2103-AY2122S1/pe-interim#4185] [original labels: type.FeatureFlaw severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

ISO-8601 format is meant to encode valid dates only. The error message implicitly implies that input dates should be valid, so we think that there does not need to be any changes made to the output message.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The error message implicitly implies that input dates should be valid, so we think that there does not need to be any changes made to the output message.

It does not. It merely states that the format is wrong, not the fact that the data is wrong.

:question: Issue severity

Team chose [severity.Low] Originally [severity.VeryLow]

Reason for disagreement: [replace this with your explanation]