Generated Masked function return false for any field when field mask is nil but should return true

yeqown / protoc-gen-fieldmask

Generate FieldMask utility functions for protobuf

MIT License

34 stars 9 forks source link

Generated Masked function return false for any field when field mask is nil but should return true #5

Closed vaidasn closed 2 years ago

vaidasn commented 2 years ago

FieldMask documentation clearly states that in case the field mask field is not set (i.e. is nil) then the mask should be treated as including all fields, see https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#fieldmask . Generated Masked_$field functions should return true for any field in case field mask is nil but instead it returns false for the case.