0.7.0 build findings - Githubissues

bollwyvl commented 1 year ago

Congrats on 0.7.0, and thanks for lunr.py!

Some quick notes working downstream on conda-forge:

the PyPI readme is blank
the javascript folder for acceptance tests is not included

Neither of these were blocking that PR, as we already pulled the JS from the GitHub snapshot and don't interact with the PyPI HTML, but these might be inconvenient for users and other downstreams.

Some other little things:

120 would really be quite lovely!
- Missing that ability has tempted me to see if lunr.js will run under js2py to get richer results back, even if it was slower/bigger to generate :blush:
- if you had any guidance on where that might be injected, i'd be happy to try my hand at it
lunr.py (with nltk) works great in pyodide, which means it also works quite well in jupyterlite
- live demos could be added to the documentation site, either "the hard way" through manually building a site and adding it to html_static_paths, or through the sphinx plugin

Thanks again!

yeraydiazdiaz commented 1 year ago

Hey @bollwyvl, thanks for the heads up, I'll try to amend the readme and the missing folder soon which should be straight forward.

I'll see if I have time to look into #120 as well, though I'm a bit tight on time.

bollwyvl commented 1 year ago

Thanks again, just shipped 0.7.0.post1, using only the sdist :tada:

yeraydiazdiaz / lunr.py

0.7.0 build findings #134

120 would really be quite lovely!