yerfor / GeneFace

GeneFace: Generalized and High-Fidelity 3D Talking Face Synthesis; ICLR 2023; Official code
MIT License
2.52k stars 294 forks source link

Hard coded env variables #167

Open DaltonSchutte opened 1 year ago

DaltonSchutte commented 1 year ago

There are a number of environment variables that are hard coded into bash and python scripts throughout v1.1.0. How many of these are critical to the functioning of the package for using new target persons?

Perhaps not an issue as much as a recommendation, but, the files should be fixed to consistently accept arguments since there are a mix of bash and python scripts that either have hard coded overwrites of environment variables or expect those environment variables as arguments.