search

yeriomin / YalpStore

Download apks from Google Play Store
GNU General Public License v2.0
2.39k stars 260 forks source link

Code clean #535

Closed ghost closed 6 years ago

ghost commented 6 years ago

This is a automated code cleanup performed by Android Studio.

I hope those changes don't break anything. I didn't find any test and the gradle build didn't work for me either.

There are some more things that could be improved. please merge or look at the changes and perform them yourself

yeriomin commented 6 years ago

I'm sorry I can not accept this PR. It seems like most of those changes are something gradle lint would suggest if it was run on the contemporary flavor only (ICS and up). They break the legacy flavor (Froyo and up). Specifically:

Other changes are either in files copied form AOSP source or just style changes.

Lack of UI tests is definitely a problem for new contributors... I cannot promise a date, but I will add them at some point.