search

yeriomin / YalpStore

Download apks from Google Play Store
GNU General Public License v2.0
2.39k stars 260 forks source link

F-Droid fails to build Yalp #543

Closed rojoweko closed 5 years ago

rojoweko commented 6 years ago

The F-Droid build server fails with the following error message (https://f-droid.org/wiki/page/com.github.yeriomin.yalpstore/lastbuild_44):

"ERROR: Could not build app com.github.yeriomin.yalpstore: Unexpected version/version code in output; APK: '0.44-legacy' / '44', Expected: '0.44' / '44'"

Is there a "current" and a "legacy" branch of yalp now? Which one should be built by F-Droid?

licaon-kter commented 6 years ago

Yup: https://github.com/yeriomin/YalpStore/commit/18a4c2d38138bdb064bffa1cb21880fd410f899c

Unfortunately F-Droid can't (bugs with parsing iirc) pick up the suffix thing so we'll need to manually edit the metadata on each new version. :(

/LE: https://gitlab.com/fdroid/fdroiddata/commit/6a582a2b8c62c122366ca737fef3bc8547ede90a

licaon-kter commented 6 years ago

@yeriomin Can you drop the -legacy suffix? You'll still know what version is.... since it's "not-contemporary" :)

Bubu commented 6 years ago

The build succeeded now, but it's apparently not really installable on any device.

It has uses-feature: name='android.hardware.ram.low' which blocks android from installing it even on my low-end 1 GB ram phone.

Was that intended?

Edit: actually android installs the package just fine, but f-droid doesn't allow installing it because the uses feature is marked as required. :thinking:

beholders-eye commented 6 years ago

I had to install version 44-legacy from Yalp itself, can't do it from f-droid.

beerisgood commented 6 years ago

Can confirm. On my LOS 15.1 (Android 8.1) with 4GB Ram I can't install version 0.44 nor 0.45 because the -legacy prefix

Krawei commented 6 years ago

Amy Updates Here?

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

beerisgood commented 6 years ago

Push Still not fixed

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

licaon-kter commented 5 years ago

Fix it bot! Lol

ZJaume commented 5 years ago

F-droid users still cannot update :disappointed:

Bubu commented 5 years ago

For the record, g-droid apparently ignores the uses-frature thing and will happily update yalp.

beerisgood commented 5 years ago

@Bubu but that doesn't fix the problem and g-droid come from F-Droid itself

Bubu commented 5 years ago

I'd add another build to fdroid that removes this uses definition so people can upgrade to that.

It would be good if yalp could skip version code 46 for the next release then.

rojoweko commented 5 years ago

Seems to work now! ;-) Thanks a lot!