yeriomin / YalpStore

Download apks from Google Play Store
GNU General Public License v2.0
2.39k stars 259 forks source link

Fix bug: AppListActivity: progress is shown in the wrong apps when scrolling #607

Closed leoacevedo closed 5 years ago

leoacevedo commented 5 years ago

Problem On the search result screen, when starting an app download and scrolling down the results list, the download progress indicator will appear on other apps.

Cause ListItem has a reference to its View, but this reference is not updated when that view is used to render a different ListItem.

Solution Keep note of the latest ListItem for each View in ListAdapter, and when that View has switched to render a different ListItem, update the previous ListItem's reference with null.

genodeftest commented 5 years ago

This looks like it will fix fix #584 and #608.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

genodeftest commented 5 years ago

This PR is not stale.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

genodeftest commented 5 years ago

This PR is not stale.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

genodeftest commented 5 years ago

This PR is not stale.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.