search

yeriomin / play-store-api

Google Play Store protobuf API wrapper in java
GNU General Public License v3.0
324 stars 131 forks source link

A default HttpClientAdaptor #23

Closed HungUnicorn closed 6 years ago

HungUnicorn commented 6 years ago

hi,

I found this OkHttpClientAdaptor is package private. would it be better to have a default one?

https://github.com/yeriomin/play-store-api/blob/master/src/test/java/com/github/yeriomin/playstoreapi/OkHttpClientAdapter.java

yeriomin commented 6 years ago

Hello.

No, that would require making some http library a dependency. Forcing a dependency is not a good idea. The whole point of https://github.com/yeriomin/play-store-api/blob/master/src/main/java/com/github/yeriomin/playstoreapi/HttpClientAdapter.java is to let the developer choose whatever http library he wants.