1.2 Branch && Suggestions.

[ghost]

This is not one Issue, it's one suggestions for Branch 1.2 and Suggestion Nukkit

I'm watched to Issues and others code from Nukkit and code is not enought. Why i'm says that? Move, Kill, Attacks and others is caused by Packets bugged. Why them are bugged?

1. Because is incomplete. (Decode and Encode is not fully and get Gameplay some bugs.)
2. Because use function this.reset(). (This function set Packets get reseted and delete themself function for added by Nukkit. Dylan (Who develop PM-MP right now) says reset() function isn't good and them changes that to one method, one method more good. Now, PM-MP don't have bugs on Gameplay (Attack, Kill, Move, and others). and that's so good.

And my suggestion is that: Port all decode and encode methods from PM-MP (Nukkit is PM-MP old ported to Java for more performance, all knows that.) and get more good gameplay.

Nukkit have good performance, code, but bugs gameplay is why more persons not use Nukkit, other than plugins. (For me, plugins is enought).

For more easy to implement that, i observe that changes to PM-MP:

1. encode() and decode() have replaced in packets with encodePayload() and decodePayload().
2. Deleted super.reset() function.
3. More functions from BinaryStream moved to Packets.
4. Added full encodePayload() and decodePayload() methods. -> Nukkit not have full.
5. Add all packets.

Suggestion for Nukkit

And one suggestion for Nukkit: Create one Discord Group. Why? Because all uses Discord now, more players active like as Gitter 👍

@yescallop Thanks for developing Nukkit.

[ghost]

NycuRo create DiscordGroup

[sero583]

@NycuRO Respone on your wants to rename the functions, are you sure renaming the function will make any changes? No, it won't.

[ghost]

@sero583 Lol, are you kidding me? Please watch code after and before changes. It's not that.

[sero583]

@NycuRO I think you don't know how code works it can be even named ass or something, it will still work if you use it right. Changing a name won't give any more performance.

[ghost]

@sero583 -_- It's not changing a name, lol.

[sero583]

@NycuRO I don't know what the matter is if the function is called encode or encodePayload, just keep it on encode() wont matter anyways. Also did you know that MC:PE does not even cares how packets are being "prepared"/"created" if I could call it so, but in removing the reset function it may improve performance because one task in packet sending is now less and well yeah but really it does not matter how the name is called.

[ghost]

@yescallop What's your oppinion?

[SupremeMortal]

Need to be looking at ways of implementing Xbox Live authentication. It will require using either a native library or JCE Unlimited Strength policy since Java doesn't support the encryption strength used by default.

[ghost]

@SupremeMortal Why you implement Xbox Live Authentification ? All players in 1.2 need use Xbox Account for enter on server. Xbox Live Authentification on server is useless in 1.2

[SupremeMortal]

It's still possible to spoof Xbox username data so players could access other peoples accounts so it's of highest priorities.

[ghost]

@SupremeMortal Ok

[ghost]

@yescallop All packets and broken. I'm watched diference of encode and decode and much is incorrect.

Exemple Crash: (AddEntityPlayer)

Now is like that:

this.getVarInt() = this.getEntityRuntimeId();

What is in PM-MP:

this.getUnsignedVarInt() = this.getEntityRuntimeId();

And in PM-MP getEntityRuntimeId and getEntityUniqueId is int, in nukkit is long.

Man, you need fix that problems.

[SupremeMortal]

They are only simple issues that don't take long to fix.

[ghost]

@SupremeMortal I know.

[vzlomka76]

@NycuRO entityRuntimeId and entityUniqueId is long, And it has always been long

[ghost]

@vzlomka76 It's one exemple, i know that. You can watch in my PR.