search

yesdog / Waterdog

Waterdog, a Yesdog fork of Waterfall/BungeeCord that adds Bedrock support.
MIT License
186 stars 37 forks source link

Make constructServerInfo compatible with BungeeCord #109

Closed tlaundal closed 4 years ago

tlaundal commented 4 years ago

Adds an overload for ProxyServer.constructServerInfo to maintain compatibility with plugins built against the BungeeCord API. We change the function to accept more arguments, but maintain compatibility with these overloads.

This fixes the following error that could originate from plugins built against BungeeCord:

java.lang.NoSuchMethodError: net.md_5.bungee.api.ProxyServer.constructServerInfo(Ljava/lang/String;Ljava/net/InetSocketAddress;Ljava/lang/String;Z)Lnet/md_5/bungee/api/config/ServerInfo;
tlaundal commented 4 years ago

New plugin, new variety of the issue.

PlayerBalancer gives java.lang.NoSuchMethodError: net.md_5.bungee.BungeeServerInfo.<init>(Ljava/lang/String;Ljava/net/InetSocketAddress;Ljava/lang/String;Z)V.

I'll add an overload for the BungeeServerInfo constructor as well.

Alemiz112 commented 4 years ago

First commit should be right. Implement BungeeServerInfo and I can merge.

tlaundal commented 4 years ago

Give me a sec and I'll rebase so they can be merged as one commit