search

yeslayla / build-godot-action

GitHub action that builds a Godot project for multiple platforms
https://github.com/josephbmanley/build-godot-action
MIT License
130 stars 30 forks source link

Update entrypoint.sh #22

Closed Bioblaze closed 1 year ago

Bioblaze commented 1 year ago

Without this change your system just doesn't work.

The Godot 3 --export option was changed to more explicit --export-release / --export-debug / --export-pack options.

Is what it will say and just stop...

runik commented 1 year ago

all our exports are broken now. is there temp workaround until this fix will be live in next version ?

Bioblaze commented 1 year ago

Give me a bit, i'm providing a fix.

Bioblaze commented 1 year ago

That should take care of it @yeslayla they made the folder names different then how they are stored, makes no sense to me but that should fix it now.

Bioblaze commented 1 year ago

Let me know if you want anything else. I'm debating on wither or not to add code-signing support too this package @.@ or make another package to be honest.

yeslayla commented 1 year ago

Let me know if you want anything else. I'm debating on wither or not to add code-signing support too this package @.@ or make another package to be honest.

I've definitely not given it the love and support it has needed recently. I'm happy to grant contributor access. Or if you'd like to do some more substantial collaboration, I'm open to speaking privately. :)

yeslayla commented 1 year ago

Actually thinking about it, may be worth working towards a 2.0.

Bioblaze commented 1 year ago

hmm I agree @yeslayla what will 2.0 have in it? And I'll be glad to contribute since I'm using the repo :P

Bioblaze commented 1 year ago

Also add me on Discord: Bioblaze Payne#6459

Bioblaze commented 1 year ago

I think I figured out why it is not working, it is cause the project is 3 years old. :X updating with a new one and testing will tell yah if that fixes it shortly.

Bioblaze commented 1 year ago

OK @yeslayla everything is good now, Github Action Tests pass, also showcase support for Old Project, and New Project :p for 3.x and 4.x figured that was nice.

knJayden commented 1 year ago

Any chance we could get this merged and released?

yeslayla commented 1 year ago

Apologies for the delays everyone. I'll get on trying to get some major improvements here soon.

Thanks again for the contribution @Bioblaze, I'll probably reach out here eventually :)

Bioblaze commented 1 year ago

kk if you got a discord Server @yeslayla I'll join it and we can chat. I'm using this in my CI/CD ;3