search

yeslayla / build-godot-action

GitHub action that builds a Godot project for multiple platforms
https://github.com/josephbmanley/build-godot-action
MIT License
130 stars 30 forks source link

Adjusted templates folder name #29

Closed truePhilipp closed 6 months ago

truePhilipp commented 6 months ago

A change has been made in the repo used as a base for the docker container (godot-ci)

In this commit the templates folder was renamed to export_templates. This change simply adjusts the path in the entry point.

MatthewHinds commented 6 months ago

Ah I was wondering why my builds were suddenly failing with:

mkdir: created directory '/github/home/.local'
mkdir: created directory '/github/home/.local/share'
mkdir: created directory '/github/home/.local/share/godot'
mkdir: created directory '/github/home/.local/share/godot/export_templates'
cp: cannot stat '/root/.local/share/godot/templates/.': No such file or directory

Hopefully this gets merged in soon.

yeslayla commented 6 months ago

Thanks for the contribution!

truePhilipp commented 6 months ago

Thanks for the quick merge!

Will there be a release soon that integrates this change? Because at the moment builds just dont work at all…

truePhilipp commented 6 months ago

If anyone wants to use this before a new release is made, you can update your workflow to mention the specific commit hash that fixed this issue, like this:

uses: manleydev/build-godot-action@f759ed7f8fcb5137cb70873ecf663aa8a1bd998b

MatthewHinds commented 6 months ago

Thanks for the contribution!

Any chance of a release to include this fix? Thanks