search

yeslayla / build-godot-action

GitHub action that builds a Godot project for multiple platforms
https://github.com/josephbmanley/build-godot-action
MIT License
130 stars 30 forks source link

Possible duplicate export template installation #8

Closed Calinou closed 4 years ago

Calinou commented 4 years ago

Forgive me if I'm missing something, but I noticed entrypoint.sh downloads and installs export templates even though the base image also installs them. This could unnecessarily slow down actions.

yeslayla commented 4 years ago

Hello! Thanks for the interest in this action! :smile:

The export templates have to be installed in the user's home directory. The GitHub action's user is different from the one in the base image. Because of that, the action currently does template installation at runtime.

Though, I believe it would be possible to decrease build times for matrix builds by having it in the build action step. Also since the templates are already on the image, but with the wrong dir a move could be done instead of a download. I'll add both of those to my todo.

yeslayla commented 4 years ago

Correction: not user, home directory

Tadaboody commented 4 years ago

How about copying/ moving it to the right directory in your docker file?