search

yeslogic / allsorts

Font parser, shaping engine, and subsetter implemented in Rust
https://yeslogic.com/blog/allsorts-rust-font-shaping-engine/
Apache License 2.0
721 stars 21 forks source link

Simple glyph flags capacity off by one? #66

Closed wezm closed 1 year ago

wezm commented 2 years ago

I think I might have the reserved capacity for simple glyph flags off by one (too small) here:

https://github.com/yeslogic/allsorts/blob/1685cc27919b303e47ef373125de8a1339f7d1ea/src/tables/glyf.rs#L391

mikeday commented 2 years ago

Why is it number_of_contours instead of number_of_coordinates since that's when the loop stops?

wezm commented 2 years ago

Right. I think it should be number_of_coordinates.