yeslogic / fathom

🚧 (Alpha stage software) A declarative data definition language for formally specifying binary data formats. 🚧
Apache License 2.0
258 stars 14 forks source link

Use explicit type names in place of `Self` where possible #479

Closed Kmeakin closed 1 year ago

Kmeakin commented 1 year ago

Use explicit type names in place of Self where possible. Dual to https://github.com/yeslogic/fathom/pull/480

brendanzab commented 1 year ago

Let’s go with this - asking others it seems like there’s not a lot of consistency - some people using Self where if makes things clearer, and others in constructors but sometimes Self return types.