search

yeslogic / fathom

🚧 (Alpha stage software) A declarative data definition language for formally specifying binary data formats. 🚧
Apache License 2.0
258 stars 14 forks source link

Make string interner global #492

Closed Kmeakin closed 1 year ago

Kmeakin commented 1 year ago

Fixes #491

Kmeakin commented 1 year ago

Unfortunately tying the lifetime of the string to the lifetime of the symbol means we cant pass the strings by reference to pretty, and have to do some unnecessary clones. I'm pretty confident transmuting to 'static is safe, since INTERNER is never dropped.

brendanzab commented 1 year ago

Seems like we were doing that anyway at any rate. Lets go with this for now.