search

yesodweb / clientsession

Stores web session data in a client cookie, protected with authentication and encryption.
MIT License
24 stars 14 forks source link

Use URL-safe Base64 #30

Open abbradar opened 9 years ago

abbradar commented 9 years ago

I'm using this library to implement OAuth2 authorization server (particularly, my access tokens, refresh tokens and codes are all just encrypted JSONs with IDs, wrapped into different records for results to not be interchangeable). Some of them are required to be sent and received over URLs, so the result needs to be URL-safe. As a workaround for now I just convert into URL-safe Base64 before sending to client (and re-convert back when receiving). This commit changes used Base64 encoding to be URL safe. This should break existing sessions for people and I don't know how bad can this impact be. However, I think this is a good use-case for this library and it should be URL-safe out of the box.

meteficha commented 9 years ago

I think it would be rather annoying to break everyone's sessions.

We could let the code accept the old sessions while producing the new ones only. This would add complexity and be an annoyance if you deployed the old and new versions side-by-side, but would avoid making everyone re-login.

My current opinion is that while I agree that using Base64URL makes sense, your use case isn't compelling enough for the added complexity. However, if we ever did some other breaking change (e.g., #31), we should do this one, too.

abbradar commented 9 years ago

Agreed, we have a workaround for this -- let's wait for now. Should I close this or leave as-is?

meteficha commented 9 years ago

Let's leave it open as a reminder.