data-default-class -> data-default

9999years commented 3 weeks ago

data-default 0.8 deprecates data-default-class by moving the Default class from Data.Default.Class to Data.Default.

See: haskell-grpc-native/http2-client#97 See: kazu-yamamoto/crypton-certificate#11 See: haskell-tls/hs-tls#486 See: commercialhaskell/stackage#7545

Before submitting your PR, check that you've:

[x] Bumped the version number
[ ] Documented new APIs with Haddock markup
[ ] Added @since declarations to the Haddock

After submitting your PR:

[ ] Update the Changelog.md file with a link to your PR
[ ] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

kazu-yamamoto commented 3 weeks ago

Merged. Thanks!

Vlix commented 3 weeks ago

Ah, this is the PR that broke warp-tls.

Did the CI actually pass on this?

(With "broke" I mean, you can't build the new warp-tls on ANY Stackage LTS if you don't also enforce tls-2.1.2, which I feel is enormously unnecessary for a dependency that adds zero value)

kazu-yamamoto commented 3 weeks ago

I have removed ">= 0.8" from warp-tls. Sorry for your inconvenience.

yesodweb / wai

data-default-class -> data-default #1010