warp: Use more meaningful types instead of `Bool`

yesodweb / wai

Haskell Web Application Interface

MIT License

834 stars 263 forks source link

warp: Use more meaningful types instead of `Bool` #998

Closed sol closed 3 months ago

sol commented 3 months ago

The overuse of booleans for all kinds of things makes it somewhat hard to follow the code that implements HTTP/1.1 keep-alive. This is a step towards trying to improve the situation.

kazu-yamamoto commented 3 months ago

I have fixed CI and rebase this PR onto master. CI failed again. I fixed Bench but still failing.

https://github.com/kazu-yamamoto/wai/tree/ci https://github.com/kazu-yamamoto/wai/actions/runs/10244402661/job/28337330217

Vlix commented 3 months ago

I'll take a look at it tomorrow 👍

kazu-yamamoto commented 3 months ago

With my refreshed head, it is easy to fix this. I have merged this PR after rebase with my fix. Thank you for your contribution!