Added bootstrap.js from a CDN to make navbar collapse and uncollapse to work.

yesodweb / yesod-scaffold

The Yesod scaffolding, with branches for different versions.

MIT License

76 stars 39 forks source link

Added bootstrap.js from a CDN to make navbar collapse and uncollapse to work. #154

Closed frt closed 7 years ago

frt commented 7 years ago

This template includes only the bootstrap.css file, so lines like the following doesn't work. This is from the default-layout.hamlet that comes with the template:

<button type="button" .navbar-toggle.collapsed data-toggle="collapse" data-target="#navbar" aria-expanded="false" aria-controls="navbar">

To solve this I put a <script src="... in the default-layout-wrapper.hamlet, so it gets the bootstrap.js from a CDN.

snoyberg commented 7 years ago

Is this sqlite specific? It looks like it should apply to the other backends too. If so, would you be able to retarget the patch to the postgres branch so that they all receive it?

frt commented 7 years ago

Did it: #159.

snoyberg commented 7 years ago

Great, thanks! Closing this, changes will be merged from postgres.