search

yesodweb / yesod-scaffold

The Yesod scaffolding, with branches for different versions.
MIT License
75 stars 39 forks source link

Yesod scaffold port variable incompatible with Keter #189

Open SongWithoutWords opened 5 years ago

SongWithoutWords commented 5 years ago

The Yesod scaffold port environment variable is YESOD_PORT: https://github.com/yesodweb/yesod-scaffold/blob/ce163c0b2dc147d01182ffe537b016d866e5c1c5/config/settings.yml#L6

This is incompatible with the environment variable used by Keter which is PORT. The results of this discrepancy is a silent failure when deploying apps created from the Yesod scaffold with Keter, as described here: https://github.com/snoyberg/keter/issues/189.

The documentation for Keter has since been updated to warn of this discrepancy, but it would be ideal if the Yesod scaffold worked with Keter out of the box.

psibi commented 5 years ago

The prefixing of YESOD was done recently. See this thread to learn more about the reasoning: https://github.com/yesodweb/yesod/issues/1517#issuecomment-396772966

Probably keter should be updated to make it work with the new environment variable ? A fix there would be ideal, IMO.

SongWithoutWords commented 5 years ago

Wouldn't changing the variable on Keter's end run the risk of breaking existing server apps?