search

yesodweb / yesod-scaffold

The Yesod scaffolding, with branches for different versions.
MIT License
75 stars 39 forks source link

Should the DB synonym use MonadUnliftIO? #191

Closed MaxGabriel closed 5 years ago

MaxGabriel commented 5 years ago

This would allow using MonadUnliftIO functions like catch inside DB code, which seems reasonable.

The definition is currently:

-- | A convenient synonym for database access functions.
type DB a = forall (m :: * -> *).
    (MonadIO m) => ReaderT SqlBackend m a
snoyberg commented 5 years ago

Sounds reasonable to me. Want to make the change?

MaxGabriel commented 5 years ago

Sure

On Fri, Mar 15, 2019 at 7:10 AM Michael Snoyman notifications@github.com wrote:

Sounds reasonable to me. Want to make the change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yesodweb/yesod-scaffold/issues/191#issuecomment-473300542, or mute the thread https://github.com/notifications/unsubscribe-auth/ABNxIQiU9tU5u5-CKhUR1JJI6qa4tnPxks5vW6nrgaJpZM4b1WSw .

snoyberg commented 5 years ago

Fixed by #192.