search

yesodweb / yesod

A RESTful Haskell web framework built on WAI.
http://www.yesodweb.com/
MIT License
2.64k stars 373 forks source link

hash library unification #1397

Open joeyh opened 7 years ago

joeyh commented 7 years ago

I noticed that yesod depends on skein (via clientsession) and cryptohash (via yesod-auth). Meanwhile, since cryptohash is deprecated, I use cryptonite in my code. Resulting in a binary containing several copies of each hash function.

Could cryptosession and yesod-auth be switched to use cryptonite?

snoyberg commented 7 years ago

There's no reason not to, are you interested in trying out a PR for it?

On Mon, May 15, 2017, 12:53 PM Joey Hess notifications@github.com wrote:

I noticed that yesod depends on skein (via clientsession) and cryptohash (via yesod-auth). Meanwhile, since cryptohash is deprecated, I use cryptonite in my code. Resulting in a binary containing several copies of each hash function.

Could cryptosession and yesod-auth be switched to use cryptonite?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yesodweb/yesod/issues/1397, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB6BFaKuK-ENKYZvB9phfHj-c4lL6ks5r6K1TgaJpZM4NbnDx .

joeyh commented 7 years ago

Michael Snoyman wrote:

There's no reason not to, are you interested in trying out a PR for it?

Not at this time, only wanted to point out the space/complexity innefeciency I'd noticed in case it seems worth fixing.

-- see shy jo

QuLogic commented 7 years ago

Moved along a bit more by #1424; not sure if it's totally complete.