Always apply jsAttributes to scritps in body

yesodweb / yesod

A RESTful Haskell web framework built on WAI.

http://www.yesodweb.com/

MIT License

2.63k stars 371 forks source link

Always apply jsAttributes to scritps in body #1836

Closed dten closed 2 months ago

dten commented 2 months ago

Before submitting your PR, check that you've:

[x] Bumped the version number

After submitting your PR:

[x] Update the Changelog.md file with a link to your PR
[x] Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Discussion over here https://github.com/yesodweb/yesod/issues/1835 but basically right now these jsAttributes only apply if you have cached the script to a location and are unusable otherwise.

dten commented 2 months ago

Thanks, do you have any idea where this might get released?

jezen commented 2 months ago

I don't as I'm not a maintainer on Hackage, but we could ask, e.g., @psibi or @parsonsmatt.

parsonsmatt commented 2 months ago

I've uploaded yesod-core-1.6.26.0, thank you!

dten commented 2 months ago

Thanks very much