Closed ysangkok closed 4 months ago
@psibi It looks like you have maintainer rights for both yesod-auth and yesod-static. Would it be possible for you to review this?
@ysangkok Looks good to me. Can you see why the CI is failing ?
@psibi Tests are on par with master
now, that is, they only fail on MacOS, for unrelated reasons.
@ysangkok It looks like that it would require some changes to stack.yaml
file for the CI to pass: https://github.com/yesodweb/yesod/actions/runs/9946180395/job/27484737340?pr=1838
All versions of crypton contain
if impl(ghc <8.8)
buildable: False
So the builds for lts-14 can't use crypton.
I see two options:
remove compatibility for GHC 8.6 and below
I would lean towards this. CC: @snoyberg if he has any objections.
Agreed
Cryptonite has been archived on GitHub, and it has been forked to crypton. See
Tested using
This depends on
Before submitting your PR, check that you've:
@since
declarations to the Haddocks for new, public APIsAfter submitting your PR: